Performance Chat Summary: 17 January 2023
Meeting agenda here and the full chat log is available beginning here on Slack.
Announcements
- @clarkeemily: Reminder for the vote open on Explore unbundling of Performance Lab as canonical performance-oriented plugins
Focus area updates
Images
@adamsilverstein @mikeschroder
- @adamsilverstein One new thing this week: I am working on a game/testing tool that shows two images generated by WordPress and asks users which they prefer. The comparisons will cover a range of quality settings and mime types (and image engines) and we will collect data about the comparisons. My goal is both to have something fun and interactive as well as get some actual WordPress based data on image quality to help make a decision about where to set WebP default quality in core.
I’d love to have some testers/feedback here once I get it a little further developed (to be shared in future). - @pbearne I will/plan create a combined patch with dom-color with theme flags and media lib changes for core and then create a new proposal blog post on make for this new version
Following from @flixos90 comment on the media lib patch - @spacedmonkey asked if we are hoping to get dominant color into 6.2
- @pbearne would love to get it in but @spacedmonkey unsure if the 80% rule was met (is it useful for 80% of users)
- @pbearne I am hoping as this is a enhancement to the media library and the is for every one we can get it in and with the them flag it can be pulled into a theme if wanted just like you might use the icons from core in a theme
Feedback requested
- See above
- Needs Discussion (10 issues)
- Needs Dev (1 issue)
Object Cache
- @spacedmonkey: Focusing on:
- Ready to commit and has unit tests
https://github.com/WordPress/wordpress-develop/pull/3814
- Close to commit, needs review, has unit tests
https://github.com/WordPress/wordpress-develop/pull/3366
- Needs review and has unit tests
https://github.com/WordPress/wordpress-develop/pull/3544
- Needs review and has unit tests
https://github.com/WordPress/wordpress-develop/pull/3178
- Needs review and has unit tests
https://github.com/WordPress/wordpress-develop/pull/3365
- Ready to commit and has unit tests
- I have a lot of PRs that need code review ^. Some of them have been waiting since November
- Anyone on this call can take a look, that would be helpful, specially the core committers, like @flixos90 @adamsilverstein @peterwilsoncc @sergeybiryukov or @johnbillion
- I have also been looking into this – https://github.com/WordPress/gutenberg/issues/45309
- Basically, to get template / template parts for block theme, you have do a database query per part
- This can result in 10+ queries per page, even after queries are cached
- I am wondering if it makes sense to just load all template parts in single database query and them filter using PHP
- The only worry is that you may load templates you do not use or you might have say 40 templates. But that seems unlikely
- Templates are not like content, there will not be 20k templates. The benefit of using one query and one cache
Feedback requested
- See above
- Needs Discussion (4 issues)
- Needs Review (1 issue)
Measurement
N/A
- @joegrainger: Plugin Checker work in progress (mainly infrastructure right now) and coming along nicely
Feedback requested
- Needs Discussion (5 issues)
- Needs Review (1 issue)
- Needs Testing (0 issues)
JS & CSS
- No updates
Feedback requested
- Needs Discussion (4 issues)
- Needs Review (2 issues)
Database
- No updates
Feedback requested
- Needs Discussion (3 issues)
- Needs Review (2 issues)
Infrastructure
- No major updates
- @mukesh27 Update json5 to their latest versions to fix vulnerability needs a second review. If anyone has a few minutes, then please review it
Feedback requested
- Needs Discussion (7 issues)
- Needs Review (2 issues)
Open Floor
- @olliejones I’m seeing some very promising performance results from using SQLite as the persister for an object cache. Is this worth proposing as a Performance Lab module?
- Performing very well on a WooCommerce site on low-end Godaddy hosting – been doing some tests on my 100K user test site, it seems good. Also works with multisite
- @pbearne suggested yes, @olliejones will write a proposal
- @spacedmonkey +1 for this idea. Adding object caching to sites without the overhead of memcache or redis, could be massive big for smaller sites
- @adamsilverstein would be especially great for hosts that don’t support traditional object caching and won’t for some real reasons
- @olliejones Last week I asked whether there are any more-or-less standardized large-site benchmarking environments. This is why. Anything?
- @spacedmonkey You can use WP_CLI to generate 100s of posts, comments or users https://developer.wordpress.org/cli/commands/post/generate/
- @olliejones Yes. But it would be cool if we had an accepted PressStone benchmark. Maybe that turns into another module proposal.
Our next chat will be held on Tuesday, January 24, 2023 at 16:00 UTC in the #core-performance channel in Slack.
#core-js, #core-media, #performance, #performance-chat, #summary, #hosting-community